Builds for node 4+6 are failing on Travis CI
graypegg opened this issue · comments
Haven't gotten a chance to look into this, but I should have a minute tonight to resolve. I think something needs a ES6 environment.
Looks like it's floating point calculation differences. We'll have to change the deepEqual assertions to only compare fractional numbers to one-millionth accuracy or something.
I had a list of accuracy values for each colour in test/consts.js, I'll go thru and adjust those later tonight, seems to be an issue with CIELAB, might be able to cut out a couple operations which MIGHT save some accuracy
https://travis-ci.org/toish/chromatism/builds/246632620
Rounding string-based colour modes when converting to CIE-* colour spaces fixes the floating point issue!