Giters

graylog-labs / graylog-plugin-metrics-reporter

Graylog Metrics Reporter Plugins

Home Page:https://www.graylog.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Support Tags/Labels

jalogisch opened this issue · comments

commented

To make the handling of metrics easier it would be nice to have the option to use tags/lables in the metrics. This way it would be easier to work with Grafana and the data given by Graylog.

Current Metrics

org_graylog2_inputs_extractors_GrokExtractor_grok_0e0ac0c0_e7c8_11e6_846a_0050569e5d86_executionTime{quantile="0.5",} 0.0
org_graylog2_inputs_extractors_GrokExtractor_grok_2834e930_1c26_11e6_90bc_0050569e5d86_executionTime{quantile="0.5",} 0.0

Requested Metrics

org_graylog2_inputs_extractors_GrokExtractor_grok_executionTime{quantile="0.5",id="0e0ac0c0_e7c8_11e6_846a_0050569e5d86"} 0.0
org_graylog2_inputs_extractors_GrokExtractor_grok_executionTime{quantile="0.5",id="2834e930_1c26_11e6_90bc_0050569e5d86"} 0.0
commented

@jalogisch The metrics library used by Graylog doesn't support tags and not every metrics store (such as Graphite or statsd) supports tags either.

commented

Quick update for anyone looking into this:

  • dropwizard supports tags from version 4.1.8 onwards (changelog).
  • Graylog 4.0.1 uses dropwizard 4.1.9 (pom.xml). So technically it should already be possible.

Nevertheless, the approach in Graylog2/graylog2-server#9914 looks a lot more promissing.

commented
  • dropwizard supports tags from version 4.1.8 onwards (changelog).

That's only a special case for the Graphite Metrics Reporter.

Tags for metrics will be supported in Dropwizard Metrics 5.x, though.
There's no scheduled date for Dropwizard Metrics 5.0.0 GA yet.