graycoreio / magento2-cors

A Magento 2 module that enables configurable CORS Headers on the GraphQL and REST APIs

Home Page:https://packagist.org/packages/graycore/magento2-cors

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ci(all): add ci pipeline to run unit and integration tests

damienwebdev opened this issue · comments

We should add CI to ensure consistent build quality. Preferably, we should use Azure DevOps.

Currently, while tests are written, they are not run in CI.

We need to run both the integration and unit tests, and these two processes can be done in parallel.

See https://github.com/magento/adobe-stock-integration/blob/1.1-develop/.travis.yml as an example of a working Travis sample. We would need to translate this over to Azure Devops and run against PR builds and master.

  • Linting (static) (#16 and #17)
  • Unit (#18 & #19)
  • Integration
  • Api-Functional

what kind of CI are we talking about ? any specific service ?

I can add Travis CI build if needed, please let me know.

@geryjuhasz @ferfabricio we tend to use Azure DevOps, but if you have a working TravisCI I can port to Azure DevOps format.

@damienwebdev I have a package that was set up with Travis CI and codecov:

https://github.com/tecnospeed/plugnotas-php

If you can I do this setup for this package.

@ferfabricio Let's try it with that to start, see if you can get CI passing in your fork. The integration tests have a dependence on the Magento Integration Test Framework, so it may be more complicated than the setup in that package.

@geryjuhasz I've updated the description to include the ideal services, but as I said, if you can write it on a particular service and get it to work, I'll port it over to what will work for me.