Giters

graycoreio / magento2-cors

A Magento 2 module that enables configurable CORS Headers on the GraphQL and REST APIs

Home Page:https://packagist.org/packages/graycore/magento2-cors

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[FEAT] Add Magento 2.4 support

JulianZschieschang opened this issue · comments

commented

💡 Feature request

Add Magento 2.4 Support

The Desired Behavior

Installation of this module works with Magento 2.4.

Your Use Case

As a developer I want to use this module in Magento 2.4.

I tried to install this module in the following environment:

magento2-cors version: 1.3.0
Magento version: 2.4.0 
PHP Version version: 7.4.9

and got the following error message:

Problem 1
    - magento/framework 102.0.0 requires php ~7.1.3||~7.2.0 -> your PHP version (7.4.9) does not satisfy that requirement.
    - magento/framework 102.0.1 requires php ~7.1.3||~7.2.0 -> your PHP version (7.4.9) does not satisfy that requirement.
    - magento/framework 102.0.2 requires php ~7.1.3||~7.2.0 -> your PHP version (7.4.9) does not satisfy that requirement.
    - magento/framework 102.0.3 requires php ~7.1.3||~7.2.0||~7.3.0 -> your PHP version (7.4.9) does not satisfy that requirement.
    - magento/framework 102.0.2-p2 requires php ~7.1.3||~7.2.0 -> your PHP version (7.4.9) does not satisfy that requirement.
    - magento/framework 102.0.4 requires php ~7.1.3||~7.2.0||~7.3.0 -> your PHP version (7.4.9) does not satisfy that requirement.
    - magento/framework 102.0.3-p1 requires php ~7.1.3||~7.2.0||~7.3.0 -> your PHP version (7.4.9) does not satisfy that requirement.
    - magento/framework 102.0.5 requires php ~7.1.3||~7.2.0||~7.3.0 -> your PHP version (7.4.9) does not satisfy that requirement.
    - magento/framework 102.0.4-p2 requires php ~7.1.3||~7.2.0||~7.3.0 -> your PHP version (7.4.9) does not satisfy that requirement.
    - magento/framework 102.0.5-p2 requires php ~7.1.3||~7.2.0||~7.3.0 -> your PHP version (7.4.9) does not satisfy that requirement.
    - graycore/magento2-cors 1.3.0 requires magento/framework ^102.0 -> satisfiable by magento/framework[102.0.5-p2, 102.0.4-p2, 102.0.5, 102.0.3-p1, 102.0.4, 102.0.2-p2, 102.0.3, 102.0.2, 102.0.1, 102.0.0].
    - Installation request for graycore/magento2-cors ^1.3 -> satisfiable by graycore/magento2-cors[1.3.0].
commented

@JulianZschieschang I'll try to get this done over the weekend, apologies on the delay for v2.4 support, been pretty busy.

If you wanted to contribute, I'd simply need to update the CI to run against php 7.3/7.4 and v2.4. Once we have that, I can figure out what changes we would need to make to iron out the required package versioning for 2.4 support.

commented

This is closed by various PRs (#34 and #35) culminating in #36 and released as v1.3.1

commented

@damienwebdev Thanks for fix, but you forgot to bump the version in the composer.json to 1.3.1, so it's still on version 1.3.0 on packagist^^

Edit: I guess it's because you're using standard-version for release management and with version 8, they intruduced a breaking change where versions are no longer read or bumped by default from composer.json and composer.lock (https://github.com/conventional-changelog/standard-version/releases/tag/v8.0.0)

commented

@JulianZschieschang good catch, and thanks for the info. This has been fixed, and I've followed composer guidelines and removed the package version from composer.json. The versions are now entirely based upon tags.

This has been appropriately released as v1.3.2

Please trial this out, and let me know if it works!

Additionally, if you use the project, please give it a star!

commented

@JulianZschieschang if you could verify that this works for you, that'd be much appreciated!

commented

@damienwebdev for me it's working fine. Thanks for the quick fix!