Bug(withTableSettings): redundant props in withSettingsTable which shouldn't be in DOM attributes

Question

Bug(withTableSettings): redundant props in withSettingsTable which shouldn't be in DOM attributes

teleginzhenya opened this issue 3 months ago · comments

isRequired and isSelected props should me omitted from mapItemDataToProps which comes to TreeSelect.TreeList.renderItem, which exposes all item data to the renderItem as renderState.props.

Console errors

Warning: React does not recognize the `isSelected` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `isselected` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    at div
    at Box (http://localhost:7007/src_components_layout_Box_Box_tsx.iframe.bundle.js:42:3)
    at Flex (http://localhost:7007/src_components_layout_Flex_Flex_tsx.iframe.bundle.js:72:5)
    at _c2 (http://localhost:7007/src_components_useList_components_ListItemView_ListItemView_tsx-src_components_useList_hooks_-acae8c.iframe.bundle.js:69:3)
    at Draggable (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:8690:58)
    at ConnectFunction (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:9931:68)
    at PrivateDraggable (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:9042:26)
    at PublicDraggable (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:9052:32)
    at div
    at Droppable (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:9064:69)
    at ConnectFunction (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:9931:68)
    at Provider (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:9643:20)
    at App (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:7661:25)
    at ErrorBoundary (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:924:35)
    at DragDropContext (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:7790:19)
    at div
    at Box (http://localhost:7007/src_components_layout_Box_Box_tsx.iframe.bundle.js:42:3)
    at Flex (http://localhost:7007/src_components_layout_Flex_Flex_tsx.iframe.bundle.js:72:5)
    at ListContainerView (http://localhost:7007/src_components_useList_components_ListContainerView_ListContainerView_tsx-src_components_useL-3f175c.iframe.bundle.js:31:3)
    at TreeList (http://localhost:7007/src_components_TreeSelect_TreeSelect_tsx.iframe.bundle.js:37:3)
    at div
    at FocusTrap (http://localhost:7007/src_components_Portal_Portal_tsx-src_components_utils_FocusTrap_tsx-src_components_utils_laye-678600.iframe.bundle.js:123:3)
    at div
    at Transition (http://localhost:7007/vendors-node_modules_react-transition-group_esm_CSSTransition_js.iframe.bundle.js:685:30)
    at CSSTransition (http://localhost:7007/vendors-node_modules_react-transition-group_esm_CSSTransition_js.iframe.bundle.js:235:35)
    at Portal (http://localhost:7007/src_components_Portal_Portal_tsx-src_components_utils_FocusTrap_tsx-src_components_utils_laye-678600.iframe.bundle.js:29:3)
    at Popup (http://localhost:7007/src_components_Popup_Popup_tsx.iframe.bundle.js:49:3)
    at _c (http://localhost:7007/src_components_Select_components_SelectControl_SelectControl_tsx-src_components_Select_compon-6c14fc.iframe.bundle.js:366:3)
    at div
    at Box (http://localhost:7007/src_components_layout_Box_Box_tsx.iframe.bundle.js:42:3)
    at Flex (http://localhost:7007/src_components_layout_Flex_Flex_tsx.iframe.bundle.js:72:5)
    at TreeSelect (http://localhost:7007/src_components_TreeSelect_TreeSelect_tsx.iframe.bundle.js:331:3)
    at TableColumnSetup (http://localhost:7007/components-Table-__stories__-Table-stories.iframe.bundle.js:1613:5)
    at div
    at th
    at tr
    at thead
    at table
    at div
    at Table (http://localhost:7007/src_components_Table_Table_tsx.iframe.bundle.js:60:1)
    at TableWithSettings (http://localhost:7007/components-Table-__stories__-Table-stories.iframe.bundle.js:2004:7)
    at MobileProvider (http://localhost:7007/main.iframe.bundle.js:819:3)
    at ThemeProvider (http://localhost:7007/main.iframe.bundle.js:1068:10)
    at unboundStoryFn (http://localhost:7007/sb-preview/runtime.js:41:3662)
    at ErrorBoundary (http://localhost:7007/vendors-node_modules_bem-react_classname_index_js-node_modules_pmmmwh_react-refresh-webpack-p-a79f08.iframe.bundle.js:4266:439)
    at WithCallback (http://localhost:7007/vendors-node_modules_bem-react_classname_index_js-node_modules_pmmmwh_react-refresh-webpack-p-a79f08.iframe.bundle.js:4238:34)

Warning: React does not recognize the `isRequired` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `isrequired` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    at div
    at Box (http://localhost:7007/src_components_layout_Box_Box_tsx.iframe.bundle.js:42:3)
    at Flex (http://localhost:7007/src_components_layout_Flex_Flex_tsx.iframe.bundle.js:72:5)
    at _c2 (http://localhost:7007/src_components_useList_components_ListItemView_ListItemView_tsx-src_components_useList_hooks_-acae8c.iframe.bundle.js:69:3)
    at Draggable (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:8690:58)
    at ConnectFunction (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:9931:68)
    at PrivateDraggable (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:9042:26)
    at PublicDraggable (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:9052:32)
    at div
    at Droppable (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:9064:69)
    at ConnectFunction (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:9931:68)
    at Provider (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:9643:20)
    at App (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:7661:25)
    at ErrorBoundary (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:924:35)
    at DragDropContext (http://localhost:7007/vendors-node_modules_gravity-ui_icons_esm_Grip_js-node_modules_gravity-ui_icons_esm_TriangleE-693099.iframe.bundle.js:7790:19)
    at div
    at Box (http://localhost:7007/src_components_layout_Box_Box_tsx.iframe.bundle.js:42:3)
    at Flex (http://localhost:7007/src_components_layout_Flex_Flex_tsx.iframe.bundle.js:72:5)
    at ListContainerView (http://localhost:7007/src_components_useList_components_ListContainerView_ListContainerView_tsx-src_components_useL-3f175c.iframe.bundle.js:31:3)
    at TreeList (http://localhost:7007/src_components_TreeSelect_TreeSelect_tsx.iframe.bundle.js:37:3)
    at div
    at FocusTrap (http://localhost:7007/src_components_Portal_Portal_tsx-src_components_utils_FocusTrap_tsx-src_components_utils_laye-678600.iframe.bundle.js:123:3)
    at div
    at Transition (http://localhost:7007/vendors-node_modules_react-transition-group_esm_CSSTransition_js.iframe.bundle.js:685:30)
    at CSSTransition (http://localhost:7007/vendors-node_modules_react-transition-group_esm_CSSTransition_js.iframe.bundle.js:235:35)
    at Portal (http://localhost:7007/src_components_Portal_Portal_tsx-src_components_utils_FocusTrap_tsx-src_components_utils_laye-678600.iframe.bundle.js:29:3)
    at Popup (http://localhost:7007/src_components_Popup_Popup_tsx.iframe.bundle.js:49:3)
    at _c (http://localhost:7007/src_components_Select_components_SelectControl_SelectControl_tsx-src_components_Select_compon-6c14fc.iframe.bundle.js:366:3)
    at div
    at Box (http://localhost:7007/src_components_layout_Box_Box_tsx.iframe.bundle.js:42:3)
    at Flex (http://localhost:7007/src_components_layout_Flex_Flex_tsx.iframe.bundle.js:72:5)
    at TreeSelect (http://localhost:7007/src_components_TreeSelect_TreeSelect_tsx.iframe.bundle.js:331:3)
    at TableColumnSetup (http://localhost:7007/components-Table-__stories__-Table-stories.iframe.bundle.js:1613:5)
    at div
    at th
    at tr
    at thead
    at table
    at div
    at Table (http://localhost:7007/src_components_Table_Table_tsx.iframe.bundle.js:60:1)
    at TableWithSettings (http://localhost:7007/components-Table-__stories__-Table-stories.iframe.bundle.js:2004:7)
    at MobileProvider (http://localhost:7007/main.iframe.bundle.js:819:3)
    at ThemeProvider (http://localhost:7007/main.iframe.bundle.js:1068:10)
    at unboundStoryFn (http://localhost:7007/sb-preview/runtime.js:41:3662)
    at ErrorBoundary (http://localhost:7007/vendors-node_modules_bem-react_classname_index_js-node_modules_pmmmwh_react-refresh-webpack-p-a79f08.iframe.bundle.js:4266:439)
    at WithCallback (http://localhost:7007/vendors-node_modules_bem-react_classname_index_js-node_modules_pmmmwh_react-refresh-webpack-p-a79f08.iframe.bundle.js:4238:34)

Valerii Sidorenko · Answer 1 · Fri Apr 12 2024 16:20:33 GMT+0800 (China Standard Time)

fixed in #1478