Events not registering for testing `controller.trigger()`

Question

Events not registering for testing `controller.trigger()`

roeintense opened this issue 4 years ago · comments

What I'm doing:

Calling this.controller.loadModule against a feature that I've created in Botkit 4.5 to instantiate a controller with its details.

What's I expect:

this.controller._events should have registered events custom defined in a feature with controller.on(<event_name>)

What I get:

Not that. controller._events is {}.

maybe I'm missing something?

Ihor Rusinko · Answer 1 · Fri Feb 14 2020 04:30:10 GMT+0800 (China Standard Time)

Hey @roeintense ,
I've checked loadModule feature, I replaced fileBeingTested with it
https://github.com/gratifyguy/botkit-mock/blob/master/examples/botkit-slack/tests/slack_features_spec.js#L26-L27`

and passed features folder, as result._events was not empty.

Anthony Gardner · Answer 2 · Fri Feb 14 2020 07:26:18 GMT+0800 (China Standard Time)

I'll take a closer look a bit later on. Thanks for quick response.

…

On Thu, Feb 13, 2020, 2:30 PM Ihor Rusinko ***@***.***> wrote: Hey @roeintense <https://github.com/roeintense> , I've checked loadModule feature, I replaced fileBeingTested with it https://github.com/gratifyguy/botkit-mock/blob/master/examples/botkit-slack/tests/slack_features_spec.js#L26-L27` and passed features folder, as result._events was not empty. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#59?email_source=notifications&email_token=ABWEUO7COXTTEZXA7AXUA6TRCWUVHA5CNFSM4KUWI5PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELWP6AQ#issuecomment-585957122>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABWEUOZUP3LQTX5QJ6RP2W3RCWUVHANCNFSM4KUWI5PA> .

Anthony Gardner · Answer 3 · Sat Feb 15 2020 02:03:46 GMT+0800 (China Standard Time)

@ihorrusinko I had a chance to look at what you did, and I'm sorry I wasn't more clear. That's how I did it before. When fileBeingTested(this.controller) didn't work, I tried calling LoadModule directly. I'm still not getting event declarations to populate. If you can't get it to replicate easily, it's probably an error on my side. I'll continue to investigate and resubmit if necessary.