`Query` not being extended
MrSaints opened this issue · comments
It seems Graphene Federation has stopped returning an SDL with extend type Query, and instead returns type Query. I'm not sure if this is intentional, but it is not compatible with some implementations of Federation Gateway.
(EDIT: It seems perhaps it was never included by default)
Other Federation implementation seems to include this, e.g. gqlgen (Go): https://github.com/99designs/gqlgen/blob/2d8673a691deffe6ddd1f4d5f013a52dc91aef91/plugin/federation/federation.go#L223, Ariadne (Python) https://github.com/apollographql/apollo-federation-subgraph-compatibility/blob/1bc1ddd56c796f2a7ff9256d279c7780dd48f582/implementations/ariadne/schema.graphql#L65
Apollo docs seems to suggest it too, but to be honest, it's not too clear. Let me know what y'all think.
Hey there, which Federation version are you using?
@erikwrede I'm still on V1. But enabling V2 doesn't seem to help either.
AFAIK the extend is optional on type Query in Federation v2. However, we can surely add it back for both federation versions, as this should not break things. /cc @patrick91
AFAIK the
extendis optional ontype Queryin Federation v2. However, we can surely add it back for both federation versions, as this should not break things. /cc @patrick91
I'd only add it for version 1, as it might be removed in future 😊
Makes sense. @MrSaints it might be worthwhile to open a bug report at your specific Gateway implementation. Which one are you using? 😊
We're using Mercurius. I believe they have one opened already tbf, so this isn't totally Graphene Federation's problem.