graphql-kit / graphql-voyager

🛰️ Represent any GraphQL API as an interactive graph

Home Page:https://graphql-kit.com/graphql-voyager/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

NPM 2.0.0 version has major code problems

IvanSereginGitHub opened this issue · comments

render-voyager-page.js has window.addEventListener('load') with SYNC function trying to call ASYNC method (await response.json()). Not only that but await response.json() CANNOT be called like that since response is still a PROMISE, not a result object, therefore it should be either (await response).json() or it should be done SYNCHRONOUSLY.
And even after all that fixed manually, I still couldn't get past the "Loading..." because of "GraphQLVoyager.init is not a function".

Didn't test previous versions, so can't say anything about them. Please fix NPM 2.0.0 version, considering those problems - I doubt that it was tested at all...

Related: #372