Giters

graphql-kit / graphql-voyager

🛰️ Represent any GraphQL API as an interactive graph

Home Page:https://graphql-kit.com/graphql-voyager/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ESLint as linter

LunaticMuch opened this issue · comments

commented

The roadmap mentioned to adopt eslint. The adoption of eslint has definitely a bit value, but it requires the agreement on three major points:

  1. Which eslint setup shall we have?
  2. Which plugins should we use?
  3. How deep do we want to go with error fixing?

I did a first test with draft PR #234 and as expected it showed many errors, only 50% fixable.
@joeponzio was suggesting to consider AirBNB rules, which I did.

Before fixing errors, do we agree with the current eslint setup? Is there any other plugin do I need to consider/add?

Let's discuss

commented

I suggest first start with "recommended" preset from ESLint and then move forward.

How deep do we want to go with error fixing?

Ideally you just disable rules that triggered errors and enable it one by one in a separate commits (can by one PR but separate commits).