graphhopper / graphhopper

Open source routing engine for OpenStreetMap. Use it as Java library or standalone web server.

Home Page:https://www.graphhopper.com/open-source/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Wrong exit number in a roundabout if a waypoint is inside

Oliv opened this issue · comments

Describe the bug
When a waypoint is inside a roundabout, there are 2 main problems :

  • The instruction At roundabout, take exit X onto ... is on the waypoint coordinates, and not on the roundabout entrance
  • The exit count is wrong, since it counts starting from the waypoint and not the roundabout entrance

To Reproduce

Put a waypoint on a roundabout

Expected behavior

I think there are two possible behaviours:

  • Make an exception for the use case where a waypoint is inside a roundabout
  • Introduce the concept of "silent waypoints". Waypoints could be flagged a silent, and then would be used only for routing, and not for instructions

What are your thoughts on this ?

Screenshots & Logs

With a waypoint https://graphhopper.com/maps/?point=48.749273%2C2.309019&point=48.750055%2C2.30897&point=48.749432%2C2.308364&profile=car&layer=Omniscale
Capture d’écran du 2024-01-18 10-53-28

Without a waypoint https://graphhopper.com/maps/?point=48.749273%2C2.309019&point=48.749432%2C2.308364&profile=car&layer=Omniscale
Capture d’écran du 2024-01-18 11-05-34

Regards, Oliv

No idea if this simplifies something, but IMO before fixing this issue we should first introduce an extra instruction for "leaving the roundabout": #1787

Hello again,

what is the status on this bug ? This is quite an issue for us since in bike / car profile we have quite a lot of wrong instructions.

Please let me know if you don't plan to have a look at this issue, and I'll try to fix it myself.

Regards, Olivier

I don't think anyone is working on it right now.