grafana / k6-operator

An operator for running distributed k6 tests.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Allow multiple replicas to be configured via helm chart

josh-ferrell opened this issue · comments

Feature Description

Allow multiple manager replicas to be configured via helm chart for redundancy.

Suggested Solution (optional)

No response

Already existing or connected issues / PRs (optional)

No response

Hi @josh-ferrell, thanks for opening this.
AFAIR, the issue of multiple replicas wasn't raised before. k6-operator does not support multiple replicas at the moment, regardless of what installation method you use. Which in practice means that some use cases would work with multiple replicas deployed and some might not.
So independently of Helm, could you please describe the use case for having more than 1 replica?

Having multiples running across zones for resiliency is a policy of ours. I assumed with the leader election that a second wouldn't be reconciling the CRs until they became the leader. TBH I'm not very familiar with k6 yet but if you can advise as to where multiple replicas would clash I can take a look at addressing them.

@josh-ferrell I'm reviewing multiple replicas setup again and I believe you're right and we won't need to change anything. TBH, the last time I checked multiple replicas workflow was almost a year ago and leases just weren't present then (in our deps). But now it looks like yes, lease solves the issues: only one replica will reconcile the resources while the rest remain on standby.

FYI, I'll continue testing this and will come back to you (and PR) a bit later this week. And thanks again for bringing this up to attention! 😄

Closed with #329