grafana / k6-operator

An operator for running distributed k6 tests.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Avoid using "latest" in the image version deployed

rgordill opened this issue · comments

Brief summary

When using "latest", any image that replaces this tag and has any backward compatibility issue like the one in the CRD (controller-v0.0.11rc3) committed yesterday breaks the operator running.

Best practices says the sha256 id should be used instead of tags to avoid TOCTOU (see this article for example)

k6-operator version or image

controller-v0.0.11rc3

K6 YAML


Other environment details (if applicable)

No response

Steps to reproduce the problem

Git checkout with a former branch (up to controller-v0.0.11rc3)

Expected behaviour

Operator image consistent with the tag used in github to be deployed

Actual behaviour

"Last" image deployed.

Hi @rgordill, thank you for the issue. Could you please clarify, which method do you use to install the k6-operator?

We've recently added support for 2 modes of installation (bundle and Helm), neither of which should be using latest by default.

I was using the "make install", as it was the traditional approach. Thanks for the tips, I would use from now on any of the other two approaches.