Add option for reversible legend
matschaffer opened this issue · comments
We have a panel up at https://grafana.safecast.cc/d/7wsttvxGk/safecast-airnote?orgId=1&var-device_urn=note:dev:864475041076562 and got feedback the legend seems backwards (low at the top, high at the bottom).
Pretty sure @nokton was expecting something like this (from @robouden)
Looks like we can probably add .reverse() to https://github.com/panodata/grafana-map-panel/blob/5e7ae9fbebf0bd1cebd18e5c0a79c4e3217a1f42/src/worldmap.ts#L129 but might be better to make it an option if people prefer the current order.
Dear Mat,
your suggestion looks very reasonable to me. We will be happy to accept further contributions around these details.
With kind regards,
Andreas.
Yup, @nokton preferred it that way so it’s in line with our radiation maps. Not sure if you want to keep a .reverse but may come in handy in the future. Prefer the new ordering as the default!
… On Dec 26, 2020, at 4:28 PM, Mat Schaffer ***@***.***> wrote:
We have a panel up at https://grafana.safecast.cc/d/7wsttvxGk/safecast-airnote?orgId=1&var-device_urn=note:dev:864475041076562 <https://grafana.safecast.cc/d/7wsttvxGk/safecast-airnote?orgId=1&var-device_urn=note:dev:864475041076562> and got feedback the legend seems backwards (low at the top, high at the bottom).
<https://user-images.githubusercontent.com/690/103147276-3e8d1800-4797-11eb-85f7-467c16d1caca.png>
Pretty sure @nokton <https://github.com/nokton> was expecting something like this (from @robouden <https://github.com/robouden>)
<https://user-images.githubusercontent.com/690/103147288-56649c00-4797-11eb-860d-9fd9577db5ee.png>
Looks like we can probably add .reverse() to https://github.com/panodata/grafana-map-panel/blob/5e7ae9fbebf0bd1cebd18e5c0a79c4e3217a1f42/src/worldmap.ts#L129 <https://github.com/panodata/grafana-map-panel/blob/5e7ae9fbebf0bd1cebd18e5c0a79c4e3217a1f42/src/worldmap.ts#L129> but might be better to make it an option if people prefer the current order.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#85>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAITQXMYAKWM5AQ2QHKROBDSWWGDLANCNFSM4VJWD6VQ>.