Add drawing and geometry layer editing features
amotl opened this issue · comments
Within #20, we recently mentioned
We just found @anatolyza has made some changes to this fork within https://github.com/anatolyza/grafana-map-panel. He is working on integrating Leaflet-Geoman, a Leaflet plugin for drawing and editing geometry layers.
@anatolyza now said:
I will be glad to do that , but I do think that some of the added features
will not do much to promote panodata, would like to hear what features you
liked?
Dear @anatolyza,
I haven't looked into the details of your improvements yet. I was just thinking generally about that others might like your adjustments as well.
Feel free to describe your amendments in your own words here and let's see if there will be coming any conversation out of this.
With kind regards,
Andreas.
What is missing from worldmap is having the range of leaflet features available (well shown on the https://github.com/huizhong/grafana-baidumap-panel), see also #31:
- drawing shapes on the map (through coordinates or by using an online editor for figure out the GPS coords)
- single shape marker(dot, star, x) with label
- lines (ex. fixed lines on the map for things like bus routes)
- ant-path for moving vehicule/person
- dots on ant-path for moving vehicule/person (shared crosshair like props)
@anatolyza: If you have implemented something along those lines they may be of use, I think you were focused on the first point: drawing shapes on the map.
As mentioned by @amotl, you are better place to indicate if you see something that can be merged back in as you put a lot of effort in your fork!
Cheers,
Thanks for this elaboration, @xkilian.
It might sound a bit naive, but may I humbly ask where manually created/edited information will actually be stored?
The most logical is in an external JSON that would offer up all the static content. This would be loaded remotely by the plugin using one of the JSON datasources.
The data would not be edited created in the UI, unless the UI would actually manage a data in a file that would be loaded in the same manner. Maybe the new backend offered by Grafana would offer a method to manage local data in the UI.
Though I think that is a nice to have, I think most people would be happy to edit manually a JSON file and keep it in a version management system.
ie. We already have a web UI to manage configuration files that are then submitted in a variety of manners to whatever system is required.
Something like this would be great. Sample hereby. Kibana already has something like that. https://library-dev.safecast.cc/index
I found this project but appears to be using some REALLY old Node 6 coding. I cannot get this to build at all nor does it uses a data source that is compatible with anything other than GlobalNOC.
I really really want this. It would make my NOC Dashboards epic.
https://github.com/GlobalNOC/globalnoc-networkmap-panel/tree/dependabot/npm_and_yarn/eslint-4.18.2
I also just discovered Leaflet.Path.Drag.