gpg-rs / gpgme

GPGme bindings for Rust

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Context::pinentry_mode should take `&self` not `self`

ooesili opened this issue · comments

The current signature of pinentry_mode is this:

fn pinentry_mode(self) -> PinentryMode

I feel like it should be this:

fn pinentry_mode(&self) -> PinentryMode

It seems overkill to have a method that seems to be nothing more than a getter take ownership of self.