gperftools / gperftools

Main gperftools repository

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

tcmalloc_and_profiler removed

ct1n opened this issue · comments

commented

The tcmalloc_and_profiler target was removed in 9dfab2c

Was this intentional? It seems it was quite used. The conan recipe breaks because of this.

It wasn't removed. Only cmake support for doing it (which we still don't get fully right) was amputated. And specifically a huge number of tests were failing indicating possible and likely issues with .so-s and .a-s. Another related comment is here: #1518 (comment)

Again, cmake support was and is best-effort. I was thinking, lets merge it and give it chance to improve. Instead I get people jumping ahead and doing somewhat sophisticated stuff with it (judging by conan thing you're referring to). I.e. someone spent nontrivial effort, invested own time to create dependency that shouldn't be created. Makes me sad and unsure what to do.

So closing and assuming this is the answer. Question was "why". Answer is "it didn't work" (for the fullest extent of meaning of "work").

If you're one of those numerous people who somehow feel strongly about all things cmake, please consider implementing this missing support you want.