Accordion opening and closing animation
gouravkhunger opened this issue · comments
The accordion just toggles the visibility of the text for now. It would be great if the text has a sliding down animation on being visible, and a sliding up animation on being dismissed.
Check line 152 of Accordion.kt file
I can give it a try, can you assign it to me please 😄
Sure, go ahead :)
Sorry, assigned to myself by mistaked 😂
@gouravkhunger I've submitted my PR, please have a look at it, Thank You.
I can add a gif or video of the sample if you want 😃
Sure, adding the gif would help me to merge it faster, else I have to clone and test myself 😂
2021_10_03_19_53_39.mp4
@gouravkhunger I have attached a sample animation.
Hey that's good, but the thing is I have tried this approach, the problem here is that there is duel animation.
If you slow down this animation and look at the frames, you would see that a space comes down before the actual texts is sliding down, and I wanted something that would make the text animate all on itself and make its space as it comes down.
Right now, it is first creating some space for itself, and then showing the animation.
Thanks a lot for the PR, if you could resolve the above issue, then I would be really happy to merge it :)
Sure, I'll try to fix that