Updated to latest versions and best practices
Toxicable opened this issue · comments
Just took a quick look through the project and noticed a few things that could do with updating so that we're up to update with the latest versions and best practices.
- Updated to to v5
- Move subscribes to
| asyncwhere appropriate - Update to rxjs v5.5 and use lettables
- Add a linter (prittifier?)
- Swap
HttpforCttpClient - Add Unit and e2e tests
- component selector prefixing
- classes -> interfaces
-
(<any>Object)->Object - remove nested subscribes
👍 Going to do the upgrade to v5 including CLI changes
Also, there are no tests, so adding tests would be nice as well 😉
@EricSimons If you have some time to look at the referenced PRs here & possibly merge them would be cool. It's the Angular GDE squat working here, with the official order from @StephenFluin to update this repo here 😂
@juristr so sorry about the delay, been afk a ton the past few days 😅 Thanks so much for putting together these PR's!! Just merged 👍
@EricSimons no worries man, I was just kidding 😉. Hopefully me or @Toxicable can submit some further PRs to also adjust the remaining "issues"
Yup, ill be doing the rxjs 5.5 / lettables later this evening
@Toxicable this app is now fully in angular5. Can you please describe me main things that are not yet in ng-5.
@irfanmayo0786 I'm confused, this example app is using Angular v5
my mean is that this app was first in angular-2. I'm just asking now it's fully updated in angular 5.
@irfanmayo0786 Yep, it's now using Angular 5 (as of this commit). What's still missing are the points at the very beginning of this issue which haven't been checked yet. Those are more like best practices that should be implemented in Angular version 5 apps.
thanks @juristr
Closing this since most of what was here is done.
The other things have their own issues
@wilfredonoyola I don't have a plan.
Feel free to send us a PR
For e2e tests I'd consider using Cypress instead of Protractor.