gothinkster / angular-realworld-example-app

Exemplary real world application built with Angular

Home Page:https://angular.realworld.how/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Consider to import ionicons package by adding to angular.json instead of reference in index.html ?

tvdinh opened this issue · comments

Hi,

I guess I'd start with asking if there is any special reason why importing the ionicons css in the index.html itself ?

  <link href="https://unpkg.com/ionicons@4.2.2/dist/css/ionicons.min.css" rel="stylesheet">
  <link href="//code.ionicframework.com/ionicons/2.0.1/css/ionicons.min.css" rel="stylesheet" type="text/css">

Should the ionicons package is added to package.json and css path is added to styles: [] in angular.json ? (which is supposed to be best practice ?)

Tuan