gothinkster / angular-realworld-example-app

Could the missing subscription management on the auth component create some leaking problems? Is it OK to do it like this in a real-world app?

checkout this line:

Line 32 in 7410c67

this.route.url.subscribe(data => {

and also again few lines below:

Line 51 in 7410c67

.subscribe(

@carballosa
Sometimes that is OK to not unsubscribe (where the source of the observable will relinquish the resource).
I've created a PR to put a context on this:
#153
The note here explains this:
https://angular.io/guide/router#observable-parammap-and-component-reuse
Also check Ben Lash comments from Ng Conf closing panel:
https://www.youtube.com/watch?v=PjHIqx0w4do
Cheers!

Missing subcriptions management on auth component