gotham-rs / gotham

A flexible web framework that promotes stability, safety, security and speed.

Home Page:https://gotham.rs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Lower tokio required features

ar3s3ru opened this issue Β· comments

Hello πŸ‘‹

I was looking through the dependencies of the project and I found this:

tokio = { version = "0.2.6", features = ["full"] }

Does Gotham really need the full feature-set of Tokio in order to function? That brings a lot of dependencies in...

commented

We probably don't need all features of tokio ... we should keep this in mind when upgrading to tokio 0.3 / hyper 0.14, I see little reason to change it right now.

I'm working on lowering the requirements, will try to post a PR shortly πŸ‘

As for tokio 0.3, hyper dependency is a blocker, so I would keep these two features separate.