goraft / raft

UNMAINTAINED: A Go implementation of the Raft distributed consensus protocol.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

go test -race fails

tmc opened this issue · comments

I haven't looked into whether not these are legitimate races or test-only races but they should be cleaned up so go test -race is useful.

@traviscline Thanks for submitting the bug. The race detector was passing for a while but we must have gotten lazy. :)

I'll fix the issues and change Travis CI to use the race detector on every build.

@benbjohnson @traviscline
Most the race is caused by debugln, and some other minor issues. We will fix it as thing is getting stable.

Looks like these races still exist. Is this something that's looking to be addressed? Should I look into some of these and submit pull-requests?

@erikstmartin I still want to address those races but I haven't had the time so far. If you want to send some PRs that'd be great. Otherwise I'll try to fix them in the near future.

@benbjohnson I will take care about this very soon.