1build support for windows os

Question

1build support for windows os

gopinath-langote opened this issue 5 years ago · comments

Gopinath Langote commented 5 years ago

Description

Support 1build for Windows - Os

Acceptance Criteria

Able to use all functionality of 1build on Windows OS
Run tests on Windows platform (on CI/CD Travis CI or GitHub Actions)

diptag · Answer 1 · Sat Oct 19 2019 22:37:24 GMT+0800 (China Standard Time)

I would like to take this up.

Gopinath Langote · Answer 2 · Sat Oct 19 2019 22:39:48 GMT+0800 (China Standard Time)

@diptag sure. go for it.

diptag · Answer 3 · Sat Oct 19 2019 23:49:09 GMT+0800 (China Standard Time)

In many places path are being joined using path1 + "/" + path2. Instead path/filepath package's filepath.Join(path1, path2) function can be used.

diptag · Answer 4 · Sun Oct 20 2019 18:07:02 GMT+0800 (China Standard Time)

The logrusorgru/aurora package is not supported on Windows as it uses ANSI colors. What do you suggest?

Gopinath Langote · Answer 5 · Sun Oct 20 2019 18:21:37 GMT+0800 (China Standard Time)

In many places path are being joined using path1 + "/" + path2. Instead path/filepath package's filepath.Join(path1, path2) function can be used.

Sure. Make sense. Please refactor the code whenever you touch the files

The logrusorgru/aurora package is not supported on Windows as it uses ANSI colors. What do you suggest?

We can use https://github.com/fatih/color - it is an archived project but still easy to do it.

GitHub
fatih/color
Color package for Go (golang). Contribute to fatih/color development by creating an account on GitHub.

diptag · Answer 6 · Sun Oct 20 2019 22:22:05 GMT+0800 (China Standard Time)

fatih/color doesn't support windows by itself, we will have to use mattn/go-colorable for that. We can use it with logrusorgru/aurora too. And mattn/go-colorable does not support underlined or bold text.

Gopinath Langote · Answer 7 · Mon Oct 21 2019 18:55:26 GMT+0800 (China Standard Time)

AFAIK, fatih/color has support for windows https://github.com/fatih/color/blob/master/README.md#color--

GitHub
fatih/color
Color package for Go (golang). Contribute to fatih/color development by creating an account on GitHub.

diptag · Answer 8 · Tue Oct 22 2019 01:18:06 GMT+0800 (China Standard Time)

Yeah, it supports Windows, my bad. But it only works when we use the color library to print directly to console, not when we use it to pass a colored string to another fmt's print statement. So it will require to change every print statement which is using colored text. And what about support for underlined and bold text?

Gopinath Langote · Answer 9 · Tue Oct 22 2019 19:23:34 GMT+0800 (China Standard Time)

what about support for underlined and bold text?

Does fatih/color has support for Underline and Bold for all OS?

But it only works when we use the color library to print directly to consol

In general, I wanted to refactor the code and make all color printing to utility - where you can just specify the style example,

printerUtils.print(text, list<styles>)

successStyle = Style{
color = CYAN,
BOLD = true,
Underline = false
}
printerUtils.print("SUCCESS", successStyle)

With such structure - you will be able to change the library easily in future

Gopinath Langote · Answer 10 · Tue Oct 22 2019 20:49:48 GMT+0800 (China Standard Time)

I have made the change in the code.

Now - We don't need to get colored string to concat with other string.

The current implementation uses - printer.go to print color with passed style.

It will be easy to switch the color lib in the future.

al-sabr · Answer 11 · Mon Mar 30 2020 12:51:09 GMT+0800 (China Standard Time)

How far is this implemented at this moment?

Gopinath Langote · Answer 12 · Mon Mar 30 2020 12:59:23 GMT+0800 (China Standard Time)

@gdeverlant Up for grab now.