googleapis / nodejs-firestore

Node.js client for Google Cloud Firestore: a NoSQL document database built for automatic scaling, high performance, and ease of application development.

Home Page:https://cloud.google.com/firestore/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Improve TS

Gsiete opened this issue · comments

To avoid people like me from spending a long time trying to understand why this fails, this line could be changed from
precondition?: Precondition
to
precondition?: Omit<Precondition, 'exists'>

https://github.com/googleapis/nodejs-firestore/blob/319adc3ff6fdcd0ab61766d4eb8301fc8ac5431b/types/firestore.d.ts#L1469C22-L1469C34

Thank you for the suggestions. I will bring this up for team discussion.