Use es6 classes and exports in logger.ts

Question

Use es6 classes and exports in logger.ts

JustinBeckwith opened this issue 6 years ago · comments

Logger.ts currently uses the export = Logger style syntax. Lets move towards explicit exported classes or functions and es module syntax.

Kelvin Jin · Answer 1 · Tue Apr 10 2018 00:45:38 GMT+0800 (China Standard Time)

@JustinBeckwith Should we turn Logger into a class? It seems to depend on log-driver right now but maybe we can use this opportunity to change that?

Justin Beckwith · Answer 2 · Tue Apr 10 2018 05:47:41 GMT+0800 (China Standard Time)

I'm not sure if it should be a class or just exported functions 🤷‍♂️ as long as it's using es modules, I'm happy. On the log-driver dependency - I'm all for chopping out dependencies we don't need, but I am trying to avoid breaking changes to the library right now. So far I think we've kept it compatible, and at the moment I'd like to preserve the API. If we can do that while chopping the dependency, and not adding too much code, I'm all for it.