Migrate to @sindresorhus/is

Question

Migrate to @sindresorhus/is

JustinBeckwith opened this issue 6 years ago · comments

Justin Beckwith commented 6 years ago

We should use @sindresorhus/is instead of just is, because it's more consistent. PR feedback from #162

Justin Beckwith · Answer 1 · Sat Jun 09 2018 07:10:21 GMT+0800 (China Standard Time)

Blocked by sindresorhus/is#51

Chris Arnesen · Answer 2 · Thu Sep 20 2018 03:29:42 GMT+0800 (China Standard Time)

I've suggested a fix on sindresorhus's issue sindresorhus/is#51 (comment) . We'll see what he says...

Sindre Sorhus · Answer 3 · Fri Sep 28 2018 16:01:22 GMT+0800 (China Standard Time)

It's out: https://github.com/sindresorhus/is/releases/tag/v0.12.0

Chris Arnesen · Answer 4 · Fri Oct 12 2018 12:14:03 GMT+0800 (China Standard Time)

This shouldn't have "status: blocked" tag anymore ...

Zach Bjornson · Answer 5 · Tue Oct 16 2018 07:39:13 GMT+0800 (China Standard Time)

@JustinBeckwith would you be open to dropping the is-like dependency entirely? I only see six usages of it, and they appear trivial to do with vanilla JS. I'm happy to submit a PR for it.

Justin Beckwith · Answer 6 · Tue Oct 16 2018 08:49:33 GMT+0800 (China Standard Time)

Sure! A PR would be welcomed :)