Drop Promise property

Question

Drop Promise property

JustinBeckwith opened this issue 6 years ago · comments

Not a comment for this PR, but in the next semver major, can we drop support from custom Promises? Note that async/await always use native promises, so the use-case for custom promises is growing thin, and might even be footgun as things behave differently from what people might expect.

Is there a strong reason to continue supporting this? People can always do global.Promise = that.thing;

Stephen · Answer 1 · Thu Apr 19 2018 01:37:27 GMT+0800 (China Standard Time)

cc @callmehiphop -- was that just a nice thing we did, or was there a requirement or important use case?

Dave Gramlich · Answer 2 · Thu Apr 19 2018 02:50:21 GMT+0800 (China Standard Time)

It was just a nice thing. Between async/await and destructuring I don't see much of a reason to keep it around any longer.

…

On Wed, Apr 18, 2018, 1:37 PM Stephen ***@***.***> wrote: cc @callmehiphop <https://github.com/callmehiphop> -- was that just a nice thing we did, or was there a requirement or important use case? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#107 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABoNA8fhSvZQa5R3FL4pLhoyBbseSOxQks5tp3nXgaJpZM4TaevZ> .

Stephen · Answer 3 · Sat Sep 29 2018 22:08:37 GMT+0800 (China Standard Time)

Is it worth trying to figure out if we have many Bluebird users (I assume that was the most common use-case for Promise override)?

Chris Arnesen · Answer 4 · Sat Sep 29 2018 22:33:35 GMT+0800 (China Standard Time)

There are bluebird users I'm sure. Users that rely on bluebird-specific features of the promises returned by these methods would have to do global.Promise = require('bluebird') if they weren't already.

Stephen · Answer 5 · Sat Sep 29 2018 22:34:57 GMT+0800 (China Standard Time)

Ah, gotcha. Then, since we're not blocking them, or giving them a hard time, it makes sense to remove.

Justin Beckwith · Answer 6 · Sun Oct 21 2018 03:35:34 GMT+0800 (China Standard Time)

I just don't think this is worth addressing right now. This would be a semver major breaking change across the board, and that's a lot of churn for little gain. Unless anyone really objects, I am closing this out for now.