GoogleApi.Storage.V1.Api.Objects.storage_objects_copy fails for destination object with reserved chars

Question

GoogleApi.Storage.V1.Api.Objects.storage_objects_copy fails for destination object with reserved chars

jheld opened this issue 3 years ago · comments

Jason Held commented 3 years ago

Environment details

Programming language: Elixir
OS: linux
Language runtime version: 1.10.4
Package version: 0.30.0

Steps to reproduce

call the function with a destination object which has at least one reserved character in it (such as a "/")

this is in the same vein as from issue #6510

Ryota Kinukawa · Answer 1 · Fri Nov 26 2021 08:39:03 GMT+0800 (China Standard Time)

I'd like to propose a change to fix this issue by this commit pojiro@becaeaa.

This fix improves fc4b282 and only affects storage_objects_copy and storage_objects_rewrite.
I checked the generating results, pojiro@2e34288, this commit is just for checking.

Ryota Kinukawa · Answer 2 · Fri Nov 26 2021 09:10:58 GMT+0800 (China Standard Time)

@dazuma Could you check this issue and fix?

Monte Brown · Answer 3 · Fri Dec 03 2021 22:58:21 GMT+0800 (China Standard Time)

@pojiro 🙏 btw this fix resolves the encoding problems I was seeing with storage_objects_copy.

Ryota Kinukawa · Answer 4 · Mon Dec 06 2021 10:53:12 GMT+0800 (China Standard Time)

@chingor13 @dazuma I create a PR #8770 which needs a maintainer to approve running workflows. Could you see them?

Daniel Azuma · Answer 5 · Wed Dec 29 2021 04:46:01 GMT+0800 (China Standard Time)

#8770 is merged. It should regenerate tonight. Google Cloud is currently in a release freeze for the holidays in North America, so the actual library release will happen next week.