Drop dependency from certificate-transparency-go
pav-kv opened this issue · comments
Pavel Kalinnikov commented
Currently, there is a circular dependency between trillian
and certificate-transparency-go
modules:
~/go/src/github.com/google/trillian$ go mod graph | grep " github.com/google/certificate-transparency-go"
github.com/google/trillian github.com/google/certificate-transparency-go@v1.1.2-0.20210512142713-bed466244fa6
github.com/google/trillian@v1.3.14-0.20210511103300-67b5f349eefa github.com/google/certificate-transparency-go@v1.1.2-0.20210422104406-9f33727a7a18
github.com/google/trillian@v1.3.14-0.20210409160123-c5ea3abd4a41 github.com/google/certificate-transparency-go@v1.0.21
In the reverse direction:
~/go/src/github.com/google/certificate-transparency-go$ go mod graph | grep " github.com/google/trillian"
github.com/google/certificate-transparency-go github.com/google/trillian@v1.4.1-0.20220503161811-32257c5c3ca0
github.com/google/certificate-transparency-go@v1.1.2-0.20210512142713-bed466244fa6 github.com/google/trillian@v1.3.14-0.20210511103300-67b5f349eefa
github.com/google/certificate-transparency-go@v1.1.2-0.20210422104406-9f33727a7a18 github.com/google/trillian@v1.3.14-0.20210409160123-c5ea3abd4a41
The only used package from certificate-transparency-go
repository is tls
serialisation format imported here.
Martin Hutchinson commented
https://go-proverbs.github.io: A little copying is better than a little dependency
Just copy tls into an internal directory inside trillian? :-)