Giters

google / trillian

A transparent, highly scalable and cryptographically verifiable data store.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

GRPC server errors not wrapped into status

pav-kv opened this issue · comments

commented

Trillian logerver doesn't always wrap the returned errors into status. GRPC automatically wraps non-status errors into a status with code.Unknown and message err.Error().

This causes a situation where a context.DeadlineExceeded error is not labeled as codes.DeadlineExceeded [#2327]. Probably there are other cases of inconsistency.

We should make sure all paths in GRPC handlers return wrapped errors.