google / trax

Trax — Deep Learning with Clear Code and Speed

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Inconsistency in function's doc-string

jaindhairyahere opened this issue · comments

Description

Inconsistent function description at https://github.com/google/trax/blob/master/trax/layers/attention.py#L330C1-L342C23

The function states that it "Returns attention-computed per-head activations and unchanged mask." but returns only the activations.

You are right. Can I raise PR to fix it ?