Replace kRPC

Question

ciera opened this issue 9 years ago · comments

We should replace kRPC with gRPC. This will allow us to remove more kythe code from third-party.

Ciera Jaspan · Answer 1 · Fri Oct 16 2015 10:43:06 GMT+0800 (China Standard Time)

Increasing priority; if we're going to change the protocol we should do it before more external analyzers get written.

Ciera Jaspan · Answer 2 · Sat Oct 17 2015 02:27:23 GMT+0800 (China Standard Time)

We have several steps to making this work.

Fix up our third party repo and the build rules around them. It's a mess right now. We should use kythe as an example.
Add in grpc by setting GOPATH to thirdparty/go; doing a go get; adding in the BUILD rules needed for all of this.
Make it possible for grpc to generate service stubs from proto. This requires modifying bazel config (plugins=grpc, search for this in kythe for an example) and adding the implicit grpc dependencies. Kythe added this to their proto build rules with has_services flag. We're probably just going to want all of kythe's build rules for grpc.
Switch our code over to using grpc.

Ciera Jaspan · Answer 3 · Sat Oct 17 2015 12:28:38 GMT+0800 (China Standard Time)

Part 1 is complete, D145.