google / scaaml

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Improve code quality

kralka opened this issue · comments

Ideas:

  • Set up automation of tests and code quality checks
  • Add docstrings
  • Improve formatting (yapf)
  • Fix typing (mypy)
  • Work in linter advice (pylint)
  • Run spell checker

Fix typing idea: Use Literal type hint for split (bevare of Python3.7 compatibility) #37 (comment)

General refactoring: Turn ['train', 'test', 'holdout'] into a constant in scaaml/io/dataset.py

General refactoring: Turn old formatting into f-strings.

FYI
With PRs #63 and #64 being merged, I now enforced yapf to be green to merge any new PR.

It could be nice having dataclasses for parameters that we use everywhere together. For instance: #75 (comment)