Support Node 12

Question

Support Node 12

nolanmar511 opened this issue 5 years ago · comments

Maggie Nolan Edmonds commented 5 years ago

Right now, this is blocked because binaries won't build when using 12.3.0 (because of nodejs/node#27803), and the Node 12 alpine image currently uses 12.3.0.

But, in a couple days, I assume that will be sorted out, and otherwise pprof-nodejs seems to be working with Node 12.

Maggie Nolan Edmonds · Answer 1 · Tue Jun 04 2019 05:05:58 GMT+0800 (China Standard Time)

The latest node:12-alpine image uses 12.3.1.

So this is unblocked there.

Maggie Nolan Edmonds · Answer 2 · Fri Jul 19 2019 23:40:21 GMT+0800 (China Standard Time)

The agent has been released since #70, so prebuilt binaries are available.

However, we're still blocked on setting up unit testing by googleapis/google-cloud-node#2923.

I re-purposed this issue to be a bit more general and capture supporting Node 12 in pprof-nodejs (which, I think, requires getting unit tests working).