google / nomulus

Top-level domain name registry service on Google Cloud Platform

Home Page:https://registry.google

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Automatically detect the version of webdriver docker image

hstonec opened this issue · comments

We started using BrowserWebDriverContainer in #112 to provision the browser as BrowserWebDriverContainer can detect the correct version of the docker image based on the webdriver library version in the classpath. This helps reduce the burden of making all versions of webdriver related library compatible with each other.

However, the screenshot tests started failing from yesterday in both TravisCI(link) and Kokoro(link), and we cannot reproduce the issue locally. We suspect the issue is that BrowserWebDriverContainer picked up a different version when the build was executed in TravisCI and Kokoro. So, we rolled back the change in #208 and then both builds succeeded.

Therefore, we need to find another to automatically detect the version instead of having this hard-coded version in the test.

We also tried to add new BrowserWebDriverContainer.withCapabilities(new ChromeOptions()) call by following testcontainer's smaple code, but it still didn't work.

See: https://travis-ci.com/hstonec/nomulus/jobs/221790067