google / nogotofail

An on-path blackbox network traffic security testing tool

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Local interface address detection broken on Fedora 21

danielkza opened this issue · comments

The local interface address detection in nogotofail/mitm/util/ip.py parses ifconfig output, assuming it conforms to the inet addr: <addr> format, but that isn't true on Fedora 21. Here is a piece of the output on my machine:

lo: flags=73<UP,LOOPBACK,RUNNING>  mtu 65536
        inet 127.0.0.1  netmask 255.0.0.0
        inet6 ::1  prefixlen 128  scopeid 0x10<host>
        loop  txqueuelen 0  (Local Loopback)
        RX packets 1019521  bytes 7437657641 (6.9 GiB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 1019521  bytes 7437657641 (6.9 GiB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

Notice the IP is not prefixed with addr:.

That was quick, thanks!

No problem. Let me me know if it is parsing correctly now. It parsed your example at least.