google / model-viewer

Easily display interactive 3D models on the web and in AR!

Home Page:https://modelviewer.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Missing propagation of the progress event reason

rsleyland opened this issue · comments

Description

PR #4647 added a reason to progress events. Unfortunately this reason is not being propagated properly in loading.ts.
The reason needs to be passed to the new CustomEvent() in loading.ts in order to be accessible in the ModelViewerElement.
Currently we have:
image
Which should be more like:

this.dispatchEvent(
          new CustomEvent('progress', {detail: {totalProgress: progress, reason}}));

Version

  • model-viewer: v3.4.0

Browser Affected

  • Chrome, version: xx.x.xxxx.xx
  • Edge
  • Firefox
  • IE
  • Safari

OS

  • Android
  • iOS
  • Linux
  • MacOS
  • Windows

AR

  • WebXR
  • SceneViewer
  • QuickLook