Giters

google / lisp-koans

Common Lisp Koans is a language learning exercise in the same vein as the ruby koans, python koans and others. It is a port of the prior koans with some modifications to highlight lisp-specific features. Structured as ordered groups of broken unit tests, the project guides the learner progressively through many Common Lisp language features.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

test-reduce-basics instructions are not clear

astronaut-wannabe opened this issue · comments

commented 
(define-test test-reduce-basics
    "The reduce function applies uses a supplied
     binary function to combine the elements of a
     list from left to right."
  (assert-equal ___  (reduce #'+ '(1 2 3 4)))
  (assert-equal ___ (reduce #'expt '(2 3 2))))

This doc string doesn't really make sense, specifically the "function applies uses a" bit.

I was going to open a PR, but I am not actually sure what it is supposed to be. Maybe:

The reduce function combines the elements of a list, from left to right, by applying a supplied binary function to the list elements

commented

I guess that's a bit easier to understand. Maybe drop the 'supplied'? Feel free to make a PR.

commented

If the merged commit fixed this adequately it would be good to close the issue, otherwise to add info about what is still needed.

commented

Since there's been no update in a few years, I'm guessing the fix was adequate.