google / kati

An experimental GNU make clone

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Allow to echo @commands

luca020400 opened this issue · comments

I was wondering why @echo isn't treated like normal echo
With this small patch I was able to get it working properly
Are there any downsides allowing @echo ?
Thanks

Sorry, but I don't understand your problem. Everything are working as expected:

$ cat < tmp.mk
all:
@echo foo
EOF
$ ./ckati -f tmp.mk
foo
$ ./ckati --ninja -f tmp.mk && ninja
[1/1] build all
foo
$ ./ckati --ninja --detect_android_echo -f tmp.mk && ninja
[1/1] foo

Perhaps you are using kati with Android tree and don't like --detect_android_echo?

Apperently ckati generates the build.ninja properly, m2n doesn't
ninja doesn't decode ascii colors in the description field and m2n set the text after @echo as description ( ckati doesn't )
( Anyway m2n is just a ckati wrapper, I don't see how it could break it .. )

cat Makefile        
all:
    @echo -e "\033[0;31mTest\033[0m"

m2n && ninja
[1/1] -e \033[0;31mTest\033[0m
ckati --ninja && ninja
[1/1] build all
Test

EDIT: --gen_all_targets flag create this issue

m2n is for Android so it specifies --detect_android_echo. Please just stop using m2n.