Giters

google / kati

An experimental GNU make clone

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

multi_implicit_output_patterns test fails for GNU make 4.0

stefanb2 opened this issue · comments

commented

When executed with GNU make 4.0 it prints "FAIL" in the expected output which causes runtest.rb to abort the whole test suite.

I'm not sure what the correct approach is to fix version dependencies in tests. It seems that GNU make 4.0 always executes the recipe for the dependency of b.c.z.

commented

Suppressed the check for GNU make 4. I'm mainly using 3.81 on Linux for development and sometimes try fixing test failures with GNU make 4. It' my bad there's no policy for this kind of cases where two GNU make versions disagree. I think for most cases kati is trying to be similar to 3.81 but sometimes it follows the behavior of 4.

Feel free to suppress test cases like my change when it's impossible to make kati agree with both GNU make versions. Or, you could ignore failures which were failing even without your change, as long as the failure doesn't terminate runtest.rb like this issue.