Giters

google / kati

An experimental GNU make clone

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[PATCH] kati should ignore recursive marker in recipes

stefanb2 opened this issue · comments

commented

Test case:

$ cat Makefile.recursive 
.PHONY: default
default:
        +echo DONE

$ ckati --warn --gen_all_targets --regen --ninja -f Makefile.recursive
Makefile.recursive was modified, regenerating...
$ fgrep DONE build.ninja
 command = /bin/sh -c "+echo DONE"

$ ninja
[1/1] build default
FAILED: default
/bin/sh -c "+echo DONE"
/bin/sh: + : invalid option
Usage:  /bin/sh [GNU long option] [option] ...
...

It should be safe to simply ignore the marker during parsing as ninja doesn't set GNU make magic recursion variables anyway.