add basic follows_symlink support
redpig opened this issue · comments
It'd be nice to be able to use symlinks for (sub)directories.
Though you have workarounded the issue by not using --use_find_emulator, two issues were found thanks to your report:
- Kati thought symlink/file did not exist when symlink points a path outside the directories FindEmulator knew
- Kati's findleaves.py didn't follow symlinks and it didn't fall back to the command execution.
1 was fixed by bd3bb23
2 was fixed by b717561
As for 2, for your case (all top-level directories are symlinks) FindEmulator still just falls back to normal $(shell) command execution. This means you still don't have the performance improvement by FindEmulator (~20 secs for me), but you should be able to build your branch with --use_find_emulator after updating build/kati.
It's been performing well in a variety of test cases - thanks!