Release builds not updated since 20220228
crappycrypto opened this issue · comments
Description
When I follow the installation instructions on https://gvisor.dev/docs/user_guide/install/ the release builds are all stuck at 20220228.
This is true for:
- https://storage.googleapis.com/gvisor/releases/release/latest/x86_64/runsc
- The debian repository
It would be nice to be able to download new releases without having to compile them myself.
Steps to reproduce
Plain download
ARCH=$(uname -m)
URL=https://storage.googleapis.com/gvisor/releases/release/latest/${ARCH}
wget ${URL}/runsc
chmod +x ./runsc
./runsc --version
runsc version release-20220228.0
spec: 1.0.2-dev
Debian repo apt-cache show runsc output
Package: runsc
Architecture: amd64
Version: 20220228.0
Priority: optional
Section: contrib/devel
Maintainer: The gVisor Authors <gvisor-dev@googlegroups.com>
Filename: pool/20220228.0/binary-amd64/runsc.deb
Size: 27585436
MD5sum: 1c1bf73bcc3dac6ba37dfad2a84a6b9c
SHA1: 6b155d49687f533ed4bad2d342adf75c454eb0d9
SHA256: 6dc3daa63dad41dc70fefe66513591fb818dba14c63fd2402b351fe103e0bdbf
SHA512: 809d00b98542e2e017a8affcf6a6e849de28c8bb96a368b15a69cd1a62224f88abeed2e00119784f78a352250de3d8f204c2a523310bef2a02648e929fa55e3e
Homepage: https://gvisor.dev/
Description: gVisor container sandbox runtime
Description-md5: 1f06b287580964e3e22f378f9fb9bc03
runsc version
No response
docker version (if using docker)
No response
uname
No response
kubectl (if using Kubernetes)
No response
repo state (if built from source)
No response
runsc debug logs (if available)
No response
It looks like the issue is that buildkite by default prunes the git checkout. Acording to https://buildkite.com/docs/integrations/github#running-builds-on-git-tags the solution is to change the git fetch flags agent config. If I've read the documentation correctly this could be achieved by adding the following to .buildkite/release.yaml
env:
BUILDKITE_GIT_FETCH_FLAGS="-v --prune --tags"
@prattmic would you be able to direct this to the right owner? We don't have a fix yet for the RACK networking issue (#7406) but when we do we'd like to see latest moving forward and be able to download by release version like https://storage.googleapis.com/gvisor/releases/release/20220425/x86_64/runsc (which should exist now but nothing after 20220228 does).
🤦 I will fix this and backfill all the tags.
It needs to be set in the agent environment, so it I will backfill the builds once the updated agents come up. Thanks for pointing this out and sorry that I missed it. I will close once I've verified that the tags are published as expected.
The releases should now be backfilled (I've verified the links here). Thanks for pointing this out, and I hope it didn't cause much trouble. Your assessment was very helpful in knowing exactly what was happening (it probably would have been a lot of frustration and cursing to figure out what the heck is going on).
Just to provide some extra context: with that commit (and a few others), I had "finished" migrating the release pipeline from Google internal systems so its easier to see everything being done. I checked it on the incremental releases (e.g. the "master" build) and the wrappers were essentially identical to an internal system. BuildKite not fetching the tags was definitely an unforeseen issue and it causes just the tags (i.e. the releases) to not publish correctly. I updated the agents w/ the appropriate configuration and just rebuilt those tags which has caused the backfill to happen... as it should have the first time round.
@amscanne I don't think the changes worked as intended. A new release has been tagged release-20220502.1 but there is no new binary at https://storage.googleapis.com/gvisor/releases/release/latest/x86_64/runsc I can't see the buildkite logs anymore for the specific commit, so I can't really see why it didn't happen.
After some googling, the only issue I can find related to this behaviour is that you might need to enable a trigger both on commit and tag. See https://buildkite.com/changelog/116-build-only-branches-tags-or-both
Per #7545 the latest releases are up to date again.