revisit buffer.View's embedded pool
hbhasker opened this issue · comments
Bhasker Hariharan commented
Description
Each buffer.View embeds its own pool which embeds an array of 8 buffer structs. This optimization is questionable as well has been a source of pain because of subtle bugs with buffer aliasing when cloning PacketBuffers and reassembling fragments etc.
Steps to reproduce
No response
runsc version
No response
docker version (if using docker)
No response
uname
No response
kubectl (if using Kubernetes)
No response
repo state (if built from source)
No response
runsc debug logs (if available)
No response
github-actions commented
A friendly reminder that this issue had no activity for 120 days.
Lucas Manning commented
Fixed with new buffer pooling implementation