google / gvisor

Application Kernel for Containers

Home Page:https://gvisor.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Don't pass protocol numbers/addresses to methods in ingress path

ghananigans opened this issue · comments

Similar to #6537, we might be able to drop protocol numbers/addresses from the ingress path and hold it in the packet buffer.

However, this may require repurposing pkt.{Network, Transport}ProtocolNumber to mean different things in ingress/egress packets.

For outgoing packets, they will be the protocol number for a header that is set by the protocol before being passed to the lower protocol.

For incoming packets, they will be the protocol number for the next-layer protocol where the header may not yet be set. Note that pkt.{Network, Transport}ProtocolNumber is currently only set when parsing succeeds on the ingress path. This would need to be updated so that the next-layer protocol number is set when the previous layer successfully parses.

A friendly reminder that this issue had no activity for 120 days.

This issue has been closed due to lack of activity.