Drop LinkEndpoint.AddHeader/Reorganize packet endpoint delivery
ghananigans opened this issue · comments
It seems like AddHeader is only used to support adding a link header to an outgoing packet before delivering the packet to a packet endpoint. However, we should be artificially adding a header just for the sake of packet endpoints.
For outgoing packets, we should deliver packets to packet endpoints right before the packet is delivered to the driver. For incoming packets, we should deliver packets to the packet endpoint right when we receive the packet from the driver.
Note that 2d9b33c removed the packetsocket link which allowed for deliver of a packet to a packet endpoint from a link endpoint, but we still artificially added the link header. We may need to bring back a packetsocket link endpoint which is responsible for delivering packets to packet endpoints close to the driver
Note that LinkEndpoints that need to add a header can continue to do so without having to expose AddHeaders through an interface.
A friendly reminder that this issue had no activity for 120 days.
This issue has been closed due to lack of activity.