Giters

google / gvisor

Application Kernel for Containers

Home Page:https://gvisor.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Share control message logic between network Endpoint

arthurpi opened this issue · comments

commented

Description

UDP, RAW & ICMP endpoints all need similar code to handle receiving control messages (they share SOL_SOCKET, SOL_IP, SOL_IPV6 cmsgs). To avoid duplication, they should use common facilities to populate these control messages.

Steps to reproduce

No response

runsc version

No response

docker version (if using docker)

No response

uname

No response

kubectl (if using Kubernetes)

No response

repo state (if built from source)

No response

runsc debug logs (if available)

No response

commented

maybe to generalize

gvisor/pkg/tcpip/transport/raw/endpoint.go

Line 96 in ce194f2

func newEndpoint(s *stack.Stack, netProto tcpip.NetworkProtocolNumber, transProto tcpip.TransportProtocolNumber, waiterQueue *waiter.Queue, associated bool) (tcpip.Endpoint, tcpip.Error) {
for reuse?

commented

A friendly reminder that this issue had no activity for 120 days.

commented

This issue has been closed due to lack of activity.