Use network protocol default ttl instead of a hardcoded one
arthurpi opened this issue · comments
Description
In sentry, instead of defining a local DefaultTTL of 64, we should retrieve the configured DefaultTTL (via the DefaultTTLOption).
In pkg/sentry/socket/netstack/netstack.go
This can be done by using stack.NetworkProtocolOption(protocolNumber, DefaultTTL)
Steps to reproduce
No response
runsc version
No response
docker version (if using docker)
No response
uname
No response
kubectl (if using Kubernetes)
No response
repo state (if built from source)
No response
runsc debug logs (if available)
No response
Seems to be an easy fix.
I am not sure if there is any design decision for the constant. I could pick this up if no one else is working on the issue.
closed the issue as the commit 2b2f9ea914bd52b7155f5643d7975f38b3331b58 is merged