google / guava

Google core libraries for Java

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Issue with `graph`-related release notes for `32.1.3`

jbduncan opened this issue · comments

The release notes for 32.1.3 say,

  • graph: Fixed the behavior of Graph/ValueGraph views for a node when that node is removed from the graph.

However, I believe this was rolled back, and so the respective text in the release notes should be removed.

What do you think?

Thanks. If I did things right, the release does not contain the rollback because I released from an earlier commit (plus a cherry pick): https://github.com/google/guava/commits/v32.1.3

This of course raises the question of whether it should contain the rollback :) We rolled back because we broke another project's test, but we ended up finding that the bug was in the test, and then graph change merely exposed it. (The graph change had previously exposed another old, mysterious bug, so it has a pretty good track record already :)) We have a roll-forward already reviewed, so that should be coming soon.

@cpovirk Oh, you're right, silly me! Thanks for pointing out my mistake. Great to hear that the rollback was only internal test-related. :)