google / grr

GRR Rapid Response: remote live forensics for incident response

Home Page:https://grr-doc.readthedocs.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

AdminUI.google_cloud_project_id Setting name is incorrect and misleading

ryushi32 opened this issue · comments

commented

This setting should be called AdminUI.google_cloud_project_number

The IAP validation requires the project number not the project ID. These are two different things and can be very misleading to the end user that is trying to set it up (Me who spent a few hours trying to figure this out =/.)

request.user, _ = validate_iap.ValidateIapJwtFromComputeEngine(

Calls the parameter by cloud_project_id however the function ValidateIapJwtFromComputeEngine

expected_audience = "/projects/{}/global/backendServices/{}".format(

Calls it by the correct name cloud_project_number.

Notes the differences per google
The following are used to identify your project:

Project name: A human-readable name for your project.

The project name isn't used by any Google APIs. You can edit the project name at any time during or after project creation. Project names do not need to be unique.

Project ID: A customizable unique identifier for your project.

The default project ID is composed of the project name and a randomly assigned number. You can customize the project ID only during project creation.

Some words are restricted from use in project IDs. If you use restricted words in the project name, such as google or ssl, the generated project ID will not include these words.

Project number: An automatically generated unique identifier for your project.